Re: [PATCH] mips: irq: add stackoverflow detection

[Adam Jiang]

On Thu, Aug 26, 2010 at 11:00:49PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> Adam Jiang wrote:
> 
> >Add stackoverflow detection to mips arch
> 
> [...]
> 
> >diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> >index c6345f5..8fdf79e 100644
> >--- a/arch/mips/kernel/irq.c
> >+++ b/arch/mips/kernel/irq.c
> >@@ -151,6 +151,25 @@ void __init init_IRQ(void)
> > #endif
> > }
> >+#ifdef DEBUG_STACKOVERFLOW
> >+static inline void check_stack_overflow(void)
> >+{
> >+	long sp;
> >+
> >+	asm volatile("move %0, $sp" : "=r" (sp));
> >+	sp = sp & (THREAD_SIZE-1);
> >+
> >+	/* check for stack overflow: is there less than 2KB free? */
> >+	if (unlikely(sp < (sizeof(struct thread_info) + 2048))) {
> >+		printk("do_IRQ: stack overflow: %ld\n",
> >+		       sp - sizeof(struct thread_info));
> >+		dump_stack();
> >+	}
> >+}
> >+#else
> >+static inline void check_stack_overflow(void) {}
> >+#endif
> >+
> > /*
> >  * do_IRQ handles all normal device IRQ's (the special
> >  * SMP cross-CPU interrupts have their own specific
> 
>    You've dropped call check_stack_overflow() call in do_IRQ() --
> was that intentional?

Of course NO. It is awful, I have say.

I spent a lot of time to struggle with git yesterday. When I revised the
coding style problem and tried to format-patch to master branch, then I
got 2 patches but not all in one. How could I rebase my working copy and
get an all-in-one patch of this?

I tried to revert my commit and redo this patch, then I lost to calling
it in do_IRQ();

Best regards,
/Adam

> 
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/