Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio

[Rik van Riel]

On 08/27/2010 06:36 AM, Wu Fengguang wrote:
> The dirty_ratio was siliently limited in global_dirty_limits() to>= 5%.
> This is not a user expected behavior. And it's inconsistent with
> calc_period_shift(), which uses the plain vm_dirty_ratio value.
>
> Let's rip the internal bound.
>
> At the same time, fix balance_dirty_pages() to work with the
> dirty_thresh=0 case. This allows applications to proceed when
> dirty+writeback pages are all cleaned.
>
> And ">" fits with the name "exceeded" better than">=" does. Neil
> think it is an aesthetic improvement as well as a functional one :)
>
> CC: Jan Kara<jack@xxxxxxx>
> CC: Rik van Riel<riel@xxxxxxxxxx>
> CC: Peter Zijlstra<a.p.zijlstra@xxxxxxxxx>
> Proposed-by: Con Kolivas<kernel@xxxxxxxxxxx>
> Reviewed-by: Neil Brown<neilb@xxxxxxx>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
> Signed-off-by: Wu Fengguang<fengguang.wu@xxxxxxxxx>

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/