Re: [RFC PATCH 03/43] ptrace: change signature of arch_ptrace()

From: Arnd Bergmann
Date: Fri Aug 27 2010 - 10:28:49 EST


On Friday 27 August 2010, Namhyung Kim wrote:
> change type of @addr and @data into unsigned long.
>
> NOTE: This patch might break build if applied alone so should be used with
> your arch counterpart.
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>

Would it be possible to rearrange your patches so that you don't break
anything in the middle? I think merging all the trivial 'change signature'
patches into one would also make reviewing easier. Nobody in their
right mind is looking through a full series of 43 patches, especially
if they do not make sense on their own, but one patch that changes a
function signature tree-wide would be looked at by many people and can
be applied standalone.

It does make sense to keep the 'foo: clean up arch_ptrace' patches
separate though, since they are also useful on their own and need
real review by the arch maintainers.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/