[PATCH] e1000e: Intel 82571EB: Don't wait for MNG cycle on unmanaged chips

From: Kyle Moffett
Date: Fri Aug 27 2010 - 15:20:56 EST


The Intel 82571EB chipset can be used in an unmanaged configuration as a
fast dual-port Gig-E controller. Unfortunately a board constructed that
way would fail to correctly come up because the driver polls for the
completion of a management cycle that will never occur.

To resolve this problem, we disable the poll and error return on chips
whose EEPROMs indicate no management. As a protection against
misconfigured chipsets, we still delay for the entire management poll
timeout.

Signed-off-by: Kyle Moffett <Kyle.D.Moffett@xxxxxxxxxx>
---
drivers/net/e1000e/82571.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
index f654db9..36d736f 100644
--- a/drivers/net/e1000e/82571.c
+++ b/drivers/net/e1000e/82571.c
@@ -756,6 +756,13 @@ static s32 e1000_get_cfg_done_82571(struct e1000_hw *hw)
{
s32 timeout = PHY_CFG_TIMEOUT;

+ /* Don't bother polling the management registers if unmanaged */
+ if (!e1000e_check_mng_mode(hw)) {
+ hw_dbg(hw, "Unmanaged chip... skipping MNG polling cycle\n");
+ mdelay(timeout);
+ return 0;
+ }
+
while (timeout) {
if (er32(EEMNGCTL) &
E1000_NVM_CFG_DONE_PORT_0)
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/