Re: [PATCH RESEND] initialise DMA engine before MMC

[Andrew Morton]

On Fri, 27 Aug 2010 20:49:39 +0100
Chris Ball <cjb@xxxxxxxxxx> wrote:

> Hi,
> 
> Andrew, mind taking this one?
> 
> From: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)
> 
> To use DMA engine based DMA with MMC in a non-modular build, the DMA 
> engine has to initialise before MMC.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 91874e0..b713e75 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA)		+= eisa/
>  obj-y				+= lguest/
>  obj-$(CONFIG_CPU_FREQ)		+= cpufreq/
>  obj-$(CONFIG_CPU_IDLE)		+= cpuidle/
> +obj-$(CONFIG_DMA_ENGINE)	+= dma/
>  obj-$(CONFIG_MMC)		+= mmc/
>  obj-$(CONFIG_MEMSTICK)		+= memstick/
>  obj-$(CONFIG_NEW_LEDS)		+= leds/
> @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO)		+= crypto/
>  obj-$(CONFIG_SUPERH)		+= sh/
>  obj-$(CONFIG_ARCH_SHMOBILE)	+= sh/
>  obj-$(CONFIG_GENERIC_TIME)	+= clocksource/
> -obj-$(CONFIG_DMA_ENGINE)	+= dma/
>  obj-$(CONFIG_DCA)		+= dca/
>  obj-$(CONFIG_HID)		+= hid/
>  obj-$(CONFIG_PPC_PS3)		+= ps3/

erk, doing this via link ordering isn't nice.

It would be better to express this dependency via initcall levels -
core_initcall() or something.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/