Re: AMD Geode NOPL emulation for kernel 2.6.36-rc2

[Matteo Croce]

can I ignore the return value when I expect val to be non zero?
the doc says: "On error, the variable @x is set to zero."

On Fri, Aug 27, 2010 at 10:49 PM, Thomas Backlund <tmb@xxxxxxxxxxxx> wrote:
> 27.08.2010 23:15, Matteo Croce skrev:
>>
>> On Fri, Aug 27, 2010 at 8:48 PM, H. Peter Anvin<hpa@xxxxxxxxx> Âwrote:
>>>
>>> You're doing user-space references without get_user().
>>>
>>> Â Â Â Â-hpa
>>>
>>> --
>>> H. Peter Anvin, Intel Open Source Technology Center
>>> I work for Intel. ÂI don't speak on their behalf.
>>>
>>>
>>
>> Here with get_user.
>> I CC Natale which is my beta tester, he have some Alix boards running
>> 24/24
>> with my patch
>>
>> --- a/arch/x86/kernel/Makefile Â2010-08-27 19:42:01.795858001 +0200
>> +++ b/arch/x86/kernel/Makefile Â2010-08-27 19:42:12.525858001 +0200
>> @@ -88,6 +88,8 @@
>> Âobj-$(CONFIG_APB_TIMER) Â Â Â Â Â Â Â += apb_timer.o
>>
>> Âobj-$(CONFIG_K8_NB) Â Â Â Â Â += k8.o
>> +obj-$(CONFIG_GEODE_NOPL) Â Â Â += nopl_emu.o
>> +obj-$(CONFIG_GEODE_NOPL) Â Â Â += nopl_emu.o
>
> Same line added twice...
>
> --
> Thomas
>



-- 
Matteo Croce
OpenWrt developer
 _______         Â ________    __
Â|Â Â ÂÂ |.-----.-----.-----.|Â |Â |Â |.----.|Â |_
Â|ÂÂ -ÂÂ ||Â _Â |Â -__|Â ÂÂ ||Â |Â |Â ||ÂÂ _||ÂÂ _|
Â|_______||ÂÂ __|_____|__|__||________||__|Â |____|
     |__| W I R E L E S S F R E E D O M
ÂKAMIKAZE (bleeding edge) ------------------
 * 10 oz Vodka  Â Shake well with ice and strain
 * 10 oz Triple sec mixture into 10 shot glasses.
 * 10 oz lime juice Salute!
Â---------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/