Re: Comments to apparmor Makefile (and security/Makefile)

From: John Johansen
Date: Sat Aug 28 2010 - 16:33:18 EST


On 08/28/2010 12:21 PM, Sam Ravnborg wrote:
>>
>>> 8) From security/Makefile:
>>>
>>> obj-$(CONFIG_SECURITY_APPARMOR) += apparmor/built-in.o
>>> This is _not_ how we do it.
>>>
>>> We say just:
>>>
>>> obj-$(CONFIG_SECURITY_APPARMOR) += apparmor/
>>>
>>> [security/Makefile has this issue in several places]
>>>
>> okay, I set it up this way to conform to other entries in the file
>> If we are going to fix apparmor's entry we should fix them all
>
> Agreed - its better to fix them all in one go.
> I assume you do this in a follow-up patch - it is straightforward.
>

Yes, I was planning to submit as a separate patch.

thanks
john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/