[RFC PATCH 2/6] workqueue: remove redundant timer_stats_timer_set_start_info()

From: Yong Zhang
Date: Sun Aug 29 2010 - 11:05:59 EST


From: Yong Zhang <yong.zhang@xxxxxxxxxxxxx>

No need to call timer_stats_timer_set_start_info() explicitly,
add_timer_on() and add_timer() have done the right job.

After this change, we can move timer_stats_timer_*_start_info()
from include/linux/timer.h to kernel/timer.c. Outsider should not
see those functions.

Signed-off-by: Yong Zhang <yong.zhang0@xxxxxxxxx>
Cc: Tejun Heo <tj@xxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
---
kernel/workqueue.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 8bd600c..e87ffd7 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1094,8 +1094,6 @@ int queue_delayed_work_on(int cpu, struct workqueue_struct *wq,
BUG_ON(timer_pending(timer));
BUG_ON(!list_empty(&work->entry));

- timer_stats_timer_set_start_info(&dwork->timer);
-
/*
* This stores cwq for the moment, for the timer_fn.
* Note that the work's gcwq is preserved to allow
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/