Re: [PATCH] vmscan: prevent background aging of anon page in no swapsystem

From: Rik van Riel
Date: Sun Aug 29 2010 - 11:49:30 EST


On 08/29/2010 11:43 AM, Minchan Kim wrote:

This patch prevents unnecessary anon pages demotion in not-swapon and
non-configured swap system. Of course, it could make side effect that
hot anon pages could swap out when admin does swap on.
But I think sooner or later it would be steady state.
So it's not a big problem.
We could lose someting but gain more thing(TLB flush and unnecessary
function call to demote anon pages).

A agree that is not a big worry. I expect virtually all the
systems with swap space will do swapon at boot time.

I used total_swap_pages because we want to age anon pages
even though swap full happens.

Cc: Rik van Riel<riel@xxxxxxxxxx>
Cc: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: Johannes Weiner<hannes@xxxxxxxxxxx>
Reported-by: Ying Han<yinghan@xxxxxxxxxx>
Signed-off-by: Minchan Kim<minchan.kim@xxxxxxxxx>

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/