Re: [PATCH 10/11] x86: Remove unnecessary ifdefs from i387 code.

[Brian Gerst]

On Sun, Aug 29, 2010 at 3:00 PM, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
> On Sat, Aug 28, 2010 at 7:04 PM, Brian Gerst <brgerst@xxxxxxxxx> wrote:
>> Remove ifdefs for code that the compiler can optimize away on 64-bit.
>>
>> Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>
>
>> @@ -74,10 +74,8 @@ static void __cpuinit init_thread_xstate(void)
>>
>> Â Â Â Âif (cpu_has_fxsr)
>> Â Â Â Â Â Â Â Âxstate_size = sizeof(struct i387_fxsave_struct);
>> -#ifdef CONFIG_X86_32
>> Â Â Â Âelse
>> Â Â Â Â Â Â Â Âxstate_size = sizeof(struct i387_fsave_struct);
>> -#endif
>> Â}
>
> I guess this is OK but keep in mind that cpu_has_fsxr is _not_
> optimized by the compiler on 64-bit so the change probably increases
> kernel text by few bytes.
>
> Acked-by: Pekka Enberg <penberg@xxxxxxxxxx>
>

FXSR is a required feature on 64-bit, therefore cpu_has_fxsr is always true.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/