Re: [RFC PATCH 00/43] ptrace cleanups

From: Roland McGrath
Date: Sun Aug 29 2010 - 20:15:08 EST


I am fine with the s/long/unsigned long/ signature changes. Adding
temporaries to avoid the repeated casts is fine too. All that will
compile away to the same code we have now. But please do it without
changing put_user/get_user calls to copy_{to,from}_user. With a
temporary or two you'll still have fewer casts than before. IMHO you
should at least do a separate follow-on patch for anything that actually
changes the compiled code vs just the cosmetic type cleanups.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/