Re: Linux 2.6.36-rc3

[Torsten Kaiser]

On Mon, Aug 30, 2010 at 12:53 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On 08/29/2010 12:24 PM, Torsten Kaiser wrote:
>> I'm still seeing the regression from -rc1 that the start of the early
>> serial output only contains garbage.
[snip]
> this one should fix the problem.
>
> please check

Yes, this fixes it:
Aug 30 06:44:19 treogen syslog-ng[2940]: syslog-ng shutting down;
version='3.1.2'
[ 1232.914095] Restarting system.

Decompressing Linux... Parsing ELF... done.
Booting the kernel.
[    0.000000] Linux version 2.6.36-rc3 (root@treogen) (gcc version
4.4.4 (Gentoo 4.4.4-r1 p1.0, pie-0.4.5) ) #1 SMP Sun Aug 29 19:03:00
CEST 2010
[    0.000000] Command line: fastboot earlyprintk=serial,ttyS0,115200
console=ttyS0,115200 console=tty1 crypt_root=/dev/md3 radeon.modeset=1
video=1280x1024
[    0.000000] BIOS-provided physical RAM map:
[    0.000000]  BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
[    0.000000]  BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
[    0.000000]  BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)

Thanks!

> [PATCH] x86, setup: fix earlyprint=serial,ttyS0...
>
> Torsten reported that there is garbage output,
> after commit 8fee13a48e4879fba57725f6d9513df4bfa8e9f3 (x86,
> setup: enable early console output from the decompressor)
>
> it turns out we missed the offset for that case.
>
> Reported-by: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>
> Index: linux-2.6/arch/x86/boot/early_serial_console.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/boot/early_serial_console.c
> +++ linux-2.6/arch/x86/boot/early_serial_console.c
> @@ -58,7 +58,7 @@ static void parse_earlyprintk(void)
>                if (arg[pos] == ',')
>                        pos++;
>
> -               if (!strncmp(arg, "ttyS", 4)) {
> +               if (!strncmp(arg + pos, "ttyS", 4)) {
>                        static const int bases[] = { 0x3f8, 0x2f8 };
>                        int idx = 0;
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/