Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

From: Wolfgang Mües
Date: Mon Aug 30 2010 - 03:26:37 EST


Hi,

Am 29.08.2010 23:39, schrieb Ryan Mallon:
I see this is already applied, but why all the type trickery here? Why
not just:

memcpy(dmabuf, sgbuffer, amount);
dmabuf += amount / sizeof(dmabuf);

Because this is wrong?

Maybe you mean sizeof(*dmabuf)?

The exact style of the bug fix is not important, it's important that it's fixed.

best regards

i. A. Wolfgang Muees

Hardware-Entwicklung
Leiter Pruefen & Layout
--
Auerswald Gesellschaft fuer Datensysteme mbH

Phone: +49 5306-9219-562
Fax: +49 5306-9200-94
--------------------------------------------------------------
Auerswald Gesellschaft fuer Datensysteme mbH,
Vor den Grashoefen 1, 38162 Cremlingen

Registriert beim AG Braunschweig HRB 7499
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/