Re: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P seriesGPIO level type

[Kyungmin Park]

On Mon, Aug 30, 2010 at 9:01 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> Kyungmin Park wrote:
>>
>> From: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>>
>> Samsung S5P series has common level type. It's different from S3C series.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> ---
>>  arch/arm/plat-samsung/include/plat/gpio-core.h |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h
> b/arch/arm/plat-
>> samsung/include/plat/gpio-core.h
>> index e358c7d..c8681e0 100644
>> --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
>> +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
>> @@ -14,6 +14,12 @@
>>  #define GPIOCON_OFF  (0x00)
>>  #define GPIODAT_OFF  (0x04)
>>
>> +#define S5P_GPIO_LEVEL_LOW           (0x00)
>> +#define S5P_GPIO_LEVEL_HIGH          (0x01)
>> +#define S5P_GPIO_EDGE_FALLING                (0x02)
>> +#define S5P_GPIO_EDGE_RISING         (0x03)
>> +#define S5P_GPIO_EDGE_BOTH           (0x04)
>
> Why should we change the name of definition from S5P_EXTINT_XXX?
> If we use that, we don't need to change other files.

External interrupt is one of GPIOs. and it's used for GPIO interrupt.
Do you want to use the EXTINT at generic gpio function?

Also change the name format as IRQ_TYPE_* style.

Thank you,
Kyungmin Park

>
>> +
>>  #define con_4bit_shift(__off) ((__off) * 4)
>>
>>  /* Define the core gpiolib support functions that the s3c platforms may
>> --
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/