Re: [RFC PATCH] GPIO: add control of powerdown modes and pull-up/down configurations.

[Grant Likely]

On Mon, Aug 30, 2010 at 11:35 AM, David Brownell <david-b@xxxxxxxxxxx> wrote:
>
>
> --- On Mon, 8/30/10, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> wrote:
>
>> From: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
>> Subject: [RFC PATCH] GPIO: add control of powerdown modes and pull-up/down configurations.
>
> NAK.

Seconded.  I completely agree with David's comments.

g.

>
> Note that Documentation/gpio.txt specifies such
> pinmux/configuration as out of scope.  There isn't
> even uniformity of models about such things between
> SOCs (and ASICs etc).
>
> Put these kinds of things in arch-specific code,
> which has good reason to know about all the ways
> each platform differs from others, and to cope.
>
> Look at OMAP and AT91 for some examples of SOCs
> which have addressed these issues cleanly, and
> without committing mayhem on the GPIO framework.
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/