Re: [PATCH v2] GPIO: add support for 74HC164 serial-in/parallel-out 8-bit shift register

[Florian Fainelli]

Hi David,

On Tuesday 31 August 2010 01:43:04 David Brownell wrote:
> generic to all
> 
> > 74HC164 chips
> 
> Not just HC-series logic, also HCT, AC, etc (as
> I noted previously).
> 
> I'm glad you took NXP (one of the N vendors)
> out of the name, but I think you should also
>  take the logic series out; "74x164 might be sufficiently generic.

Allright, I will respin with those changes. Note that I chose to prefix the 
data structures with gen_ (for obvious C language reasons), I hope this is 
fine.

>            
> 
> > pdata->gpio_pin_clk, err);
> 
> I'm a bit puzzled why you don't just hook the
> chip up using standard SPI signals... ISTR they
> matched up directly to what the chip needs, so
> no GPIOs were needed for interface glue.

The board this driver is being used on had no SPI signals left I think, so it 
was hooked up on separate GPIO lines (which cannot be muxed to the GPIO pad).
--
Florian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/