Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB inip_fragment

[Herbert Xu]

On Tue, Aug 31, 2010 at 07:20:31AM +0200, Eric Dumazet wrote:
> Le lundi 30 août 2010 à 19:21 -0400, Bandan Das a écrit :
> > > 
> > > I wonder if we want this.
> > > 
> > > Maybe setting skb->local_df = 1 in bridge should be enough ?
> > > 
> > > 
> > Thanks Eric for looking at this. Indeed, setting local_df to 1 seems to be enough! I will
> > respin and post a different patch.
> > 
> 
> Reading this stuff again, I wonder if we should not revert commit
> 17762060c25590bfddd  and use a different trick

I don't quite understand the problem.  Does the packet actually
have IP options? If not why is it trying to look at IP options?

If it does have options, then we should parse options in the
bridge driver before passing it to the IP stack (or just drop
the packet).

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/