Re: [PATCH RFC] pid: make setpgid() system call use RCU read-side critical section

[David Howells]

Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:

>  	write_lock_irq(&tasklist_lock);
>  
>  	err = -ESRCH;
> +	rcu_read_lock();
> ...
> +	rcu_read_unlock();
>  	write_unlock_irq(&tasklist_lock);

I would generally put the rcu lock outside the IRQ disabled section on the
basis that it's better to keep the amount of time we have interrupts disabled
shortest.

> Located-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

'Reported-by' might be more consistent with what others use.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/