Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering

[Chase Douglas]

On Tue, 2010-08-31 at 23:06 +0200, Henrik Rydberg wrote:
> On 08/31/2010 10:58 PM, Chase Douglas wrote:
> 
> > On Tue, 2010-08-31 at 22:34 +0200, Henrik Rydberg wrote:
> >> On 08/31/2010 08:41 PM, Chase Douglas wrote:
> >>
> >>> The Magic Mouse device is very precise. No driver filtering of input
> >>> data needs to be performed.
> >>>
> >>> Signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
> >>> Acked-by: Michael Poole <mdpoole@xxxxxxxxxxx>
> >>> ---
> >>
> >>
> >> I am still not sure this is a good idea. Bandwidth from MT devices is a big
> >> deal. A statement roughly how much data comes out of mtdev (which does the
> >> filtering for type A devices) before and after this change would be reassuring.
> > 
> > As it is right now, hid-magicmouse doesn't support MT slots. I think all
> > the fuzz code ends up comparing in the MT case is between one touch and
> > another touch, not between one touch's current location and its previous
> > location. If I'm correct, then it means a fuzz > 0 is incorrect for
> > non-slotted MT devices.
> > 
> > In fact, the code in drivers/input/input.c around line 194 looks like it
> > discards defuzzing in this case, so one could say this patch is making
> > things more correct :).
> 
> 
> For type A devices, the filtering is performed in userspace, in mtdev, in the
> same manner as it would have been performed in the kernel in the MT slot case.
> Therefore, knowing the amount of messages coming out of mtdev is a direct
> measurement of the effect of filtering.

Yes, but we're only interested in the kernel driver when reviewing this
patch. Leaving the fuzz in as it is has no effect right now on ABS_MT_*
axes. On the other axes, such as the touch orientation, it's probably
more harmful than good.

> > Now a fuzz > 0 for the non-MT ABS axes may be useful, but this device
> > exhibits no jitter, and we're not really worried about bandwidth in the
> > single touch case.
> 
> 
> The jitter is better measured by the actual amount of events.

I would agree, if there was any jitter to measure. However, I can hold
my fingers on the device and not see any extra events due to jitter.
Simple inspection via evtest has convinced me.

-- Chase

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/