Re: [PATCH] drivers/net/pch_gbe: Cleanup stats use

[Stephen Hemminger]

On Tue, 31 Aug 2010 11:38:35 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

>  struct pch_gbe_stats {
> -	signed char stat_string[ETH_GSTRING_LEN];
> -	int sizeof_stat;
> -	int stat_offset;
> +	signed char string[ETH_GSTRING_LEN];
> +	size_t size;
> +	size_t offset;
>  };

Is this driver really using 'signed char' here?
Should just be 'char' for a simple string.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/