Re: [RFD][checkpatch] warnings on space in front of labels

From: Peter Zijlstra
Date: Thu Sep 02 2010 - 10:31:17 EST


On Thu, 2010-09-02 at 10:18 -0400, Steven Rostedt wrote:
>
> There's a new warning that I've seen lately. It is about complaining
> about spaces starting on a new line.
>
> WARNING: please, no space for starting a line,
> excluding comments
> #90: FILE: trace-read.c:612:
> + again:$
>
>
> Comments are currently the exception, but I would also like to add
> labels too.

I really hate that /^ label/ stuff and I'm removing them everywhere I
can.


> I really prefer the space in front of the label. In fact, I think it
> should be the default.
>
> But could we at least remove the warning for spaces in front of labels?

No, kill those spaces with prejudice.

> What do others think?

I'd prefer to run a script over the kernel and remove all those silly spaces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/