Re: [PATCH 1/2] Input: stmpe-ts - remove input_free_device() in stmpe_ts_remove()

[Luotao Fu]

Hi,

On Fri, Sep 3, 2010 at 3:30 AM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> No need to call input_free_device() after input_unregister_device().
>

yeah right. The device is input_unregister_device unregisters the
device already. Thx for fixing this.

Acked-by: Luotao Fu <devtty0@xxxxxxxxx>

> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
>  drivers/input/touchscreen/stmpe-ts.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 656148e..0339d1d 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -361,7 +361,6 @@ static int __devexit stmpe_ts_remove(struct platform_device *pdev)
>        platform_set_drvdata(pdev, NULL);
>
>        input_unregister_device(ts->idev);
> -       input_free_device(ts->idev);
>
>        kfree(ts);
>
> --
> 1.7.2
>
>
>
>

cheers
Luotao Fu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/