Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

[Masayuki Ohtake]

Hi Eric

Thank you for your information.
I will confirm other drivers.

Thanks, Ohtake(OKISemi)
----- Original Message ----- 
From: "Eric Dumazet" <eric.dumazet@xxxxxxxxx>
To: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx>
Cc: "Stephen Hemminger" <shemminger@xxxxxxxxxx>; "Sam Ravnborg" <sam@xxxxxxxxxxxx>; "Joe Perches" <joe@xxxxxxxxxxx>;
"LKML" <linux-kernel@xxxxxxxxxxxxxxx>; "ML netdev" <netdev@xxxxxxxxxxxxxxx>; "Greg Rose" <gregory.v.rose@xxxxxxxxx>;
"Maxime Bizon" <mbizon@xxxxxxxxxx>; "Kristoffer Glembo" <kristoffer@xxxxxxxxxxx>; "Ralf Baechle" <ralf@xxxxxxxxxxxxxx>;
"John Linn" <john.linn@xxxxxxxxxx>; "Randy Dunlap" <randy.dunlap@xxxxxxxxxx>; "David S. Miller" <davem@xxxxxxxxxxxxx>;
"MeeGo" <meego-dev@xxxxxxxxx>; "Wang, Qi" <qi.wang@xxxxxxxxx>; "Wang, Yong Y" <yong.y.wang@xxxxxxxxx>; "Andrew"
<andrew.chih.howe.khor@xxxxxxxxx>; "Intel OTC" <joel.clark@xxxxxxxxx>; "Foster, Margie" <margie.foster@xxxxxxxxx>;
"Toshiharu Okada" <okada533@xxxxxxxxxxxxxxx>; "Tomoya Morinaga" <morinaga526@xxxxxxxxxxxxxxx>; "Takahiro Shimizu"
<shimizu394@xxxxxxxxxxxxxxx>
Sent: Friday, September 03, 2010 10:43 PM
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH


> Le vendredi 03 septembre 2010 a 22:32 +0900, Masayuki Ohtake a ecrit :
> > Hi Eric and Stephen
> >
> > Thank you for your suggestion.
> >
> > I tried modification of "dev->hard_header_len".
> > However, there was no changed to a format of SKB received by kernel.
> >   [Header:14octet] + [payload]
> >
> > So, I can not a single memcpy.
>
> Hmm, maybe you did this at the wrong place ?
>
> Take a look at other drivers how they do this
>
> (network stack default hard_header_len to 14, in net/ethernet/eth.c,
> function ether_setup())
>
>
> find drivers/net | xargs grep -n hard_header_len
>
> Example in drivers/net/wan/hdlc.c
>
> static void hdlc_setup_dev(struct net_device *dev)
> {
>         /* Re-init all variables changed by HDLC protocol drivers,
>          * including ether_setup() called from hdlc_raw_eth.c.
>          */
>         dev->flags               = IFF_POINTOPOINT | IFF_NOARP;
>         dev->priv_flags          = IFF_WAN_HDLC;
>         dev->mtu                 = HDLC_MAX_MTU;
>         dev->type                = ARPHRD_RAWHDLC;
>         dev->hard_header_len     = 16;
>         dev->addr_len            = 0;
>         dev->header_ops          = &hdlc_null_ops;
> }
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/