Re: [PATCHv11 2.6.36-rc2-tip 3/15] 3: uprobes: Slot allocationfor Execution out of line(XOL)

[Peter Zijlstra]

On Fri, 2010-09-03 at 22:10 +0530, Srikar Dronamraju wrote:
> > > +   vma = find_vma(mm, addr);
> > > +
> > > +   /* Don't expand vma on mremap(). */
> > > +   vma->vm_flags |= VM_DONTEXPAND | VM_DONTCOPY;
> > > +   area->vaddr = vma->vm_start;
> > 
> > Seems interesting,.. why not use install_special_mapping(), that's what
> > the VDSO uses.
> 
> Okay, I hadnt looked at install_special_mapping earlier so I will take a
> look and incorporate it. However I am not clear at this point what
> install_special_mapping is giving us here.  Also install_special_mapping
> is already defining its own vm_ops esp a close method thats doesnt seem
> to be doing anything. So at this point I am not clear how we are link
> the vm_ops, the close method and install_special_mapping.

What you're doing might well be the right thing, I was just wondering.

I think that, after thinking about it more, that the shmem file thing
you're doing has the added benefit that the things gets auto-magic
paging, which is a good thing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/