Re: [PATCH] regulator: wm8350-regulator - fix the logic ofchecking REGULATOR_MODE_STANDBY mode

[Mark Brown]

On Mon, Sep 06, 2010 at 02:06:07PM +0800, Axel Lin wrote:
> In wm8350_dcdc_set_mode(), we set DCx_SLEEP bit of WM8350_DCDC_SLEEP_OPTIONS
> register for REGULATOR_MODE_STANDBY mode.
> ( DCx_SLEEP bits: 0: Normal DC-DC operation 1: Select LDO mode )

> In wm8350_dcdc_get_mode(), current logic to determinate
> REGULATOR_MODE_STANDBY mode is just reverse.
> ( sleep is set should mean REGULATOR_MODE_STANDBY mode. )
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

but *please* do try to make your commit messages clearer, it's difficult
to follow what you're sayin here, mostly because you don't explain how
you determined what change to make.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/