Re: [PATCH 06/14] staging: rtl8192u: improve error path

[Kulikov Vasiliy]

On Mon, Sep 06, 2010 at 12:11 +0200, Dan Carpenter wrote:
> On Sun, Sep 05, 2010 at 10:32:41PM +0400, Kulikov Vasiliy wrote:
> > +fail2:
> > +	rtl8192_down(dev);
> > +	if (priv->pFirmware) {
> > +		kfree(priv->pFirmware);
> > +		priv->pFirmware = NULL;
> > +	}
> > +	rtl8192_usb_deleteendpoints(dev);
> > +	destroy_workqueue(priv->priv_wq);
> > +	mdelay(10);
> 
> What's this delay for?

It was copied from rtl8192_usb_disconnect(), I don't know why it has
mdelay(10). But it's better to keep the old deallocation code, it should
have the same problems (if original code has any).

-- 
Vasiliy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/