Re: [PATCH 09/14] staging: westbridge: improve error path

[walter harms]

Greg KH schrieb:
> On Mon, Sep 06, 2010 at 09:51:20AM +0200, walter harms wrote:
>> the indention should be fixed also.
> 
> Yes, the indentation for the whole file should be fixed, but that's not
> what this patch was doing.
> 
> Remember, a patch should only do one thing at a time.
> 

that is true,
but in this special case i nearly missed the #if because it is so hidden
in the code. IMHO that is enough for an exception.

re,
 wh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/