Re: [RFC][PATCH] big continuous memory allocator v2

From: Minchan Kim
Date: Tue Sep 07 2010 - 04:37:35 EST


Nice cleanup.
There are some comments in below.

On Mon, Sep 6, 2010 at 7:45 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
>
> This is a page allcoator based on memory migration/hotplug code.
> passed some small tests, and maybe easier to read than previous one.
>
> ==
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>
> This patch as a memory allocator for contiguous memory larger than MAX_ORDER.
>
>  alloc_contig_pages(hint, size, node);

I have thought this patch is to be good for dumb device drivers which
want big contiguous
memory. So if some device driver want big memory and they can tolerate
latency or fail,
this is good solution, I think.
And some device driver can't tolerate fail, they have to use MOVABLE zone.

For it, I hope we have a option like ALLOC_FIXED(like MAP_FIXED).
That's because embedded people wanted to aware BANK of memory.
So if they get free page which they don't want, it can be pointless.

In addition, I hope it can support CROSS_ZONE migration mode.
Most of small system can't support swap system. So if we can't migrate
anon pages into other zones, external fragment problem still happens.

I think reclaim(ex, discard file-backed pages) can become one option to prevent
the problem. But it's more cost so we can support it by calling mode.
(But it could be trivial since caller should know this function is very cost)

ex) alloc_contig_pages(hint, size, node, ALLOC_FIXED|ALLOC_RECLAIM);


Thanks, Kame.



--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/