Re: [patch]cfq-iosched: schedule dispatch for noidle queue

[Shaohua Li]

On Mon, 2010-09-20 at 22:02 +0800, Vivek Goyal wrote:
> On Mon, Sep 20, 2010 at 04:53:37PM +0800, Shaohua Li wrote:
> > A queue is idle at cfq_dispatch_requests(), but it gets noidle later for
> > different reasons. Unless other task explictly does unplug or all requests
> > are drained, we will not deliever requests to the disk even cfq_arm_slice_timer
> > doesn't make the queue idle. For example, cfq_should_idle() returns true
> > because of service_tree->count == 1, and then other queues are added.
> > Note, I didn't see obvious performance impacts so far with the patch, but
> > just thought this could be a problem.
> > 
> 
> Shaohua Li,
> 
> What are those reasons when an idling queue becomes a non idle one
> (without getting a new request in the queue)?
OOps, I used to add a new reason for another patch but forgot to update
the comment. So this is the only reason.

Thanks,
Shaohua

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/