Re: [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot ofcheckpatch.pl issues
From: Greg KH
Date: Wed Sep 22 2010 - 22:22:51 EST
On Wed, Sep 22, 2010 at 04:24:58PM -0700, matt mooney wrote:
> On 21:19 Mon 20 Sep , Tracey Dent wrote:
> > Fixed numerous coding style issues
> >
> The subject should be more specific as to what the patch does, such as
> "Staging: rtl8187se: r8180.h: whitespace cleanup."
>
> And the explanation in the commit should also be more specific. There are
> plenty of examples if you look through the log. Greg might except them as is,
> but any future patches should follow the advice mentioned. Next time for a
> patch of this nature remember to CC kernel-janitors too.
Why the janitor list? Do you really want that to be copied on every
cleanup patch I get like this? That would be a _lot_...
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/