Re: [PATCH] spi_mpc8xxx: issue with using definition of pram inDevice Tree

From: Scott Wood
Date: Fri Sep 24 2010 - 11:07:50 EST


On Fri, 24 Sep 2010 01:10:06 -0600
Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:

> On Thu, Sep 16, 2010 at 09:05:03AM +0200, christophe leroy wrote:
> > This patch applies to 2.6.34.7 and 2.6.35.4
> > It fixes an issue during the probe for CPM1 with definition of parameter ram from DTS
> >
> > Signed-off-by: christophe leroy <christophe.leroy@xxxxxx>
>
> I'm sorry, I don't understand the fix from the given description.
> What is the problem, and why is cpm_muram_alloc_fixed() the wrong
> thing to call on CPM1? Does CPM2 still need it?

I don't see how cpm_muram_alloc_fixed() can be used safely at all. If
you need a fixed address, it shouldn't be part of the general
allocation pool, or something else might get it first.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/