Re: hibernation hangs with ATA errors (lockup_detector bug)

[Don Zickus]

On Fri, Sep 24, 2010 at 06:10:02PM +0300, Jiri Slaby wrote:
> On 09/03/2010 04:56 PM, Don Zickus wrote:
> > On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote:
> >> On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> >>> On 06/02/2010 08:44 PM, Don Zickus wrote:
> >>>> --- a/kernel/watchdog.c
> >>>> +++ b/kernel/watchdog.c
> >>>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
> >>>>  		break;
> >>>>  	case CPU_ONLINE:
> >>>>  	case CPU_ONLINE_FROZEN:
> >>>> -		if (watchdog_enable(hotcpu))
> >>>> -			return NOTIFY_BAD;
> >>>> +		watchdog_enable(hotcpu)
> >>>
> >>> This fixes the problem indeed.
> >>
> >> Hi, was this fixed somehow? I still use this hunk and don't know if it
> >> is needed:
> > 
> > I have to go re-review the problem again.  I might have forgot to bring it
> > in.  Thanks for reminding me!
> 
> Reminder #2 :). Any updates?

No. I suck.  I was sidetracked on other stuff.  Let me put that together
today.

Thanks again for reminding me.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/