Re: [PATCH] generic-ipi: fix deadlock in __smp_call_function_single

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> Maybe.  Or maybe it papers over a scheduler bug by gratuitously adding 
> additional code which no present callsites actually need.

Hm, indeed.

We now have the scheduler bug fixed upstream. Do we really need this 
patch?

> The patch didn't update the __smp_call_function_single() kerneldoc. 
> Compare it with smp_call_function_single() and note the subtle 
> difference between "a specific CPU" and the now incorrect "on another 
> CPU".

In any case this feedback didnt get addressed AFAICS.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/