Re: [PATCHv3 2/3] watchdog: add f71862fg support

[Giel van Schijndel]

On Sun, Sep 26, 2010 at 04:32:41PM +0200, Lutz Ballaschke wrote:
> ioctl WDIOC_GETTIMELEFT and helper function added to watchdog driver 
> for common usage.
> 
> ... snip ...
> 
> +static int watchdog_time_left(void)
> +{
> +	int ret = 0;
> +
> +	mutex_lock(&watchdog.lock);
> +	ret = superio_enter(watchdog.sioaddr);
> +	if (ret)
> +		goto exit_unlock;
> +
> +	superio_select(watchdog.sioaddr, SIO_F71808FG_LD_WDT);
> +	ret = superio_inb(watchdog.sioaddr, F71808FG_REG_WD_TIME);
> +	superio_exit(watchdog.sioaddr);
> +
> +exit_unlock:
> +	mutex_unlock(&watchdog.lock);
> +	return ret;
> +}

This function still has the problem I described earlier, namely that of
returning minutes to userspace (which expects seconds) when minutes_mode
is true.

I would thus suggest not to commit this patch as it violates the
Watchdog API.

-- 
Met vriendelijke groet,
With kind regards,
Giel van Schijndel
--
"There are only two kinds of languages: the ones people complain about
 and the ones nobody uses."
  -- Bjarne Stroustrup

Attachment: signature.asc
Description: Digital signature