Re: [PATCH] x86: EuroBraille/Iris power off

[Shérab]

Hello,

Shérab (2010/09/20 10:22 +0200):
> Dear all,
> 
> Valdis.Kletnieks@xxxxxx (2010/09/13 21:45 -0400):
> > On Mon, 13 Sep 2010 17:22:49 +0200, Samuel Thibault said:
> > 
> > > Again, I'm not sure we really should try hard to make it automatically
> > > detected (and thus always enabled).  Having to pass a kernel parameter
> > > to enable the functionality is completely fine, since installing Linux
> > > on this device requires quite some tinkering already.
> > 
> > I'm agreeing that if iris_init() checks that the user passed 'irisinit.force=1'
> > on the command line or as a module parameter, and bailed immediately if it
> > wasn't passed, then doing the inb() and testing it should be safe
> > enough. [...]
> 
> Please find below a revised version of the module that does what has
> been asked.

The previous patch had a few style problem and the moduleparam.h header
was not included whereas it should have been.
The version below passes ./script/checkpatch and the missing header has
been included, so the patch should be correct now.
Moreover the patch has been updated to apply on top of current master.

Shérab.