Re: [PATCH] staging: make new character devices nonseekable

[Greg KH]

On Sun, Sep 26, 2010 at 05:31:52PM +0200, Arnd Bergmann wrote:
> As a preparation for changing the default behaviour of llseek to no_llseek,
> every file_operations structure should have a .llseek operation.
> 
> There are three new instances in staging now, which can all be changed
> into no_llseek explicitly since the devices do not need to seek.
> 
> Add nonseekable_open where appropriate, to prevent pread/pwrite as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  bcm/Bcmchar.c                    |    3 +++
>  bcm/InterfaceInit.c              |    1 +
>  ft1000/ft1000-usb/ft1000_chdev.c |    2 ++
>  3 files changed, 6 insertions(+)

Odd, this patch breaks the build, what's up?

Hm, do I need to apply it to a recent Linus version?  My staging-next
tree is 2.6.36-rc2 based, do I need to update it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/