Re: fs hang in 2.6.27.y | Fwd: [Bug 15658] New: [PATCH] x86 constant_test_bit()prone to misoptimization with gcc-4.4

From: H. Peter Anvin
Date: Mon Sep 27 2010 - 00:29:24 EST


On 09/26/2010 10:00 AM, Linus Torvalds wrote:
On Sun, Sep 26, 2010 at 4:53 AM, Michael Shigorin<mike@xxxxxxxxxxx> wrote:

The simplicity of adding that somewhat went over my head --
please find attached the corrected original patch against HEAD
with Signed-off-by: for both of us. led@ didn't change cosmetics
-- thanks for providing it anyways.

Ok, I think this patch is probably the right thing to do at this stage
- and we should think about trying to see if we can improve code
generation later.

So: "Acked-by: Linus Torvalds<torvalds@xxxxxxxxxxxxxxxxxxxx>"

Ingo/Thomas/Peter - I can take this either from the x86 tree, or
directly. Just let me know. Or do you have any alternate suggestions
that would be appropriate?


(Back home now)

Yes, this patch is clearly The Right Thing. I'll add it to the -tip tree and assuming no unexpected problems will send you a pull request tomorrow.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/