Re: [PATCH] ubifs: avoid kernel error if ubifs superblock readfails

[Artem Bityutskiy]

On Fri, 2010-09-24 at 11:54 +0200, Steffen Sledz wrote:
> * .get_sb is called on mounts with automatic fs detection too, so this
>   function should not print an error if it cannot read the superblock
>   (new behaviour conforms the other fs types)
> 
> Signed-off-by: Steffen Sledz <sledz@xxxxxxxxxxxx>
> ---
>  fs/ubifs/super.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index cd5900b..e62bb75 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -2049,8 +2049,6 @@ static int ubifs_get_sb(struct file_system_type *fs_type, int flags,
>  	 */
>  	ubi = open_ubi(name, UBI_READONLY);
>  	if (IS_ERR(ubi)) {
> -		ubifs_err("cannot open \"%s\", error %d",
> -			  name, (int)PTR_ERR(ubi));
>  		return PTR_ERR(ubi);
>  	}
>  	ubi_get_volume_info(ubi, &vi);

Hi, could you please instead turn this message into dbg_err() - in this
case we'll have the message only when debugging is enabled.

Also, please CC:

Artem Bityutskiy <dedekind1@xxxxxxxxx>
linux-mtd@xxxxxxxxxxxxxxxxxxx

Thanks!

-- 
Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/