Re: [PATCHv2] proc: making "limits" world readable

[Neil Horman]

On Mon, Sep 27, 2010 at 10:49:23AM +0200, Jiri Olsa wrote:
> On Fri, Sep 24, 2010 at 11:32:46AM -0700, Andrew Morton wrote:
> > On Fri, 24 Sep 2010 12:20:07 -0400
> > Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:
> > 
> > > On Fri, Sep 24, 2010 at 12:55:47PM +0200, Jiri Olsa wrote:
> > > > On Thu, Sep 23, 2010 at 02:56:42PM -0700, Andrew Morton wrote:
> > > > > On Tue, 21 Sep 2010 11:10:55 +0200
> > > > > Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > > > > 
> > > > > > hi,
> > > > > > 
> > > > > > I'd like to have the /proc/<pid>/limits file world readable,
> > > > > 
> > > > > Why?
> > > > > 
> > > > 
> > > > having this will ease the task of system management for large install
> > > > bases and where root privileges might be restricted
> > > > 
> > > > jirka
> > > > 
> > > I don't see a problem with making this file world readable.  Doing so would be
> > > in keeping with most of the other stats bearing files in /proc/<pid>.  The only
> > > reason I didn't make it world readable was because the getrlimit sematics
> > > previously kept limit information private to the process, and I didn't want to
> > > deviate from that.  But as long as we're not making it world writeable I think
> > > we're ok.
> > > 
> > > Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> > > 
> > 
> > hm, OK, I can't really think of any realistic problem with exposing limits.
> > 
> > The original patch had no signoff.  Please resend, with a changelog
> > which includes a *good* rationale for making the change.  For example,
> > a use case.
> > 
> thanks for feedback, the patch is attached
> 
> jirka
> 
> ---
> making the /proc/<pid>/limits file world readable.
> 
> Having the limits file world readable will ease the task of
> system management on systems where root privileges might be
> restricted. 
> 
> Having admin restricted with root proviledges, he/she could
> not check other users process' limits.
> 
> Also it'd align with most of the /proc stat files.
> 
> wbr,
> jirka
> 
> 
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/