Re: [PATCH] hwmon (coretemp): Fix build breakage if SMP isundefined

[Guenter Roeck]

On Mon, Sep 27, 2010 at 02:25:10AM -0400, Ingo Molnar wrote:
> 
> * Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> wrote:
> 
> > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> > a build breakage if CONFIG_SMP is undefined. This patch
> > fixes the problem.
> > 
> > Reported-by: Ingo Molnar <mingo@xxxxxxx>
> > Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> > Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> > 
> > ---
> >  drivers/hwmon/coretemp.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index baa842a..58a3c2d 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
> >  		list_del(&p->list);
> >  		mutex_unlock(&pdev_list_mutex);
> >  		kfree(p);
> > +#ifdef CONFIG_SMP
> >  		for_each_cpu(i, cpu_sibling_mask(cpu))
> >  			if (i != cpu && !coretemp_device_add(i))
> >  				break;
> > +#endif
> 
> Wont this result in an 'unused variable i' compiler warning?
> 
Sigh. Yes, of course. Must have been blind when I compiled it. Serves me right, 
for pushing this out in a hurry. You'll see rev2 of the patch in a minute.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/