Re: [PATCH v2] olpc_battery: Fix endian neutral breakage for s16values

[Richard A. Smith]

On 09/25/2010 02:19 PM, Daniel Drake wrote:
> From: Richard A. Smith<richard@xxxxxxxxxx>
>
> When the driver was updated to be endian neutral (8e9c7716c)
> the signed part of the s16 values was lost.  This is because be16_to_cpu()
> returns a signed value.  This patch casts the values back to a s16 number
> prior to the the implicit cast up to an int.

Seems the comment has a error.  Should be 'returns an unsigned' rather 
than signed.  Other than that it looks good.

--
Richard A. Smith  <richard@xxxxxxxxxx>
One Laptop per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/