Re: x86/hwmon: conditionalize coretemp's dependency on PCI

[Jan Beulich]

>>> On 27.09.10 at 15:02, Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> wrote:
> On Mon, Sep 27, 2010 at 08:46:54AM -0400, Jan Beulich wrote:
>> >>> On 27.09.10 at 14:16, Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> wrote:
>> > On Mon, Sep 27, 2010 at 03:08:50AM -0400, Jan Beulich wrote:
>> > [...]
>> > 
>> >> >>  
>> >> >>  config SENSORS_CORETEMP
>> >> >>  	tristate "Intel Core/Core2/Atom temperature sensor"
>> >> >> -	depends on X86 && PCI && EXPERIMENTAL
>> >> >> +	depends on X86 && EXPERIMENTAL
>> >> >> +	depends on PCI || (!MATOM && !GENERIC_CPU && !X86_GENERIC)
>> >> >>  	help
>> >> >>  	  If you say yes here you get support for the temperature
>> >> >>  	  sensor inside your CPU. Most of the family 6 CPUs
>> >> > 
>> >> > Resending my reply to this one as well. Again, apologies if there is 
>> >> > duplication.
>> >> > 
>> >> > The coretemp code unconditionally calls pci functions, even if PCI is not 
>> >> > defined.
>> >> > I am concerned that this might cause problems. It might be better to stick 
> 
>> >> > with
>> >> > the more generic dependency instead of trying to optimize too much.
>> >> 
>> >> pci.h takes care to define stub inline functions for the !CONFIG_PCI
>> >> case. It seemed largely odd for a driver like this to depend on PCI
>> >> at all, and hence I think it is more transparent to make the needs
>> >> explicit.
>> >> 
>> > Seems to me the dependency should not exist in the first place, then.
>> > Otherwise, the driver would still be disabled for GENERIC_CPU, which isn't
>> > good either.
>> 
>> Oh, not having a dependency on PCI at all would be even better.
>> I didn't dare to suggest that.
>> 
>> > Are there examples of other drivers which are not defining the PCI 
>> > dependency
>> > but are conditionally calling pci functions ?
>> 
>> I'm not aware of any, but also didn't explicitly look for such.
>> 
> It still compiles if I remove the PCI dependency and disable PCI. So that is 
> one plus.
> 
> That whole dependency is just to get the host bridge ID which is then used
> to determine tjmax. Personally I would prefer to have a wrong tjmax over not 
> having 
> coretemp at all, and the means to determine tjmax through the bridge ID is 
> kind
> of bogus anyway. So at least in this case it would make sense for me to 
> remove
> the dependency completely. Actually, we won't even change functionality,
> since tjmax is only set to a higher value for specific bridge IDs.
> 
> So, if you don't mind, please re-submit with the PCI dependency removed 
> entirely.

Hmm, no, I'd rather not - I just can't tell what implications it has
if you run on !PCI && MATOM, i.e. I wouldn't be able to really justify
that change other than by second hand knowledge (from what you
wrote above). If you're convinced the dropped dependency doesn't
make things worse, you're much better positioned to craft a respective
patch.

> Unless someone starts screaming, I'll apply that to my -next tree.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/