Re: [PATCH] MIPS: I2C: Return -ETIMEDOUT in octeon_i2c_wait() ontimeout

From: Ben Dooks
Date: Mon Sep 27 2010 - 18:13:18 EST


On Mon, Sep 27, 2010 at 10:32:06AM -0700, David Daney wrote:
> On 09/27/2010 03:55 AM, Bernhard Walle wrote:
>> It doesn't make sense to set result to -ETIMEDOUT but return 0 (success)
>> afterwards. Since there's code in octeon_i2c_start() to handle the
>> error, it should be called.
>>
>> Signed-off-by: Bernhard Walle<walle@xxxxxxxxxxxxx>
>
> Thanks for fixing this.
>
> Acked-by: David Daney <ddaney@xxxxxxxxxxxxxxxxxx>

Ok, will put into my for -rc6 branch.

--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/