Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_GPIO driver to 2.6.35

[Mark Brown]

On Tue, Sep 28, 2010 at 03:35:39PM +0900, Masayuki Ohtake wrote:

>     gpio->base = (u32)chip->pch_gpio_base_address;

This is the number that will be assigned to the first GPIO if the chip
registers successfully.

>     gpio->ngpio = 12;

This is the number of GPIOs your chip has.

>     chip->pch_gpio_base_address = pci_iomap(pdev, 1, 0);

This initialisation is incorrect and is likely to fail.  gpiolib knows
nothing of how your chip is controlled, the base is the base for the
GPIO numbers used to access GPIOs in gpiolib.  Please refer to other
gpiolib drivers for examples of how to use the gpilib APIs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/