Re: [PATCH] um: Proper Fix for f25c80a4: remove duplicate structurefield initialization

From: Linus Torvalds
Date: Wed Sep 29 2010 - 11:05:37 EST


On Wed, Sep 29, 2010 at 1:34 AM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
>
> On the other hand patch [f25c80a4] was trying to use eth_mac_addr()
> in eth_configure(), *which was the real fallout*. Because of state
> checks done inside eth_mac_addr() the address was never set. I have
> not reintroduced the memcpy wrapper, but I've put a comment for future
> cats.

Ahh. Ok, this looks fine. David, please use this instead of my broken
one that didn't do the whole thing.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/