Re: [PATCH 4/4] ste_dma40: implement support for scatterlist toscatterlist copy

[Dan Williams]

On Mon, Sep 27, 2010 at 3:57 PM, Ira W. Snyder <iws@xxxxxxxxxxxxxxxx> wrote:
> Now that the DMAEngine API has support for scatterlist to scatterlist
> copy, implement support for the STE DMA40 DMA controller.
>
> Cc: Linus Walleij <linus.ml.walleij@xxxxxxxxx>
> Cc: Per Fridén <per.friden@xxxxxxxxxxxxxx>
> Signed-off-by: Ira W. Snyder <iws@xxxxxxxxxxxxxxxx>
> ---
>  drivers/dma/ste_dma40.c |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 17e2600..cd48859 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -1857,6 +1857,18 @@ err:
>        return NULL;
>  }
>
> +static struct dma_async_tx_descriptor *
> +d40_prep_sg(struct dma_chan *chan,
> +           struct scatterlist *dst_sg, unsigned int dst_nents,
> +           struct scatterlist *src_sg, unsigned int src_nents,
> +           unsigned long dma_flags)
> +{
> +       if (dst_nents != src_nents)
> +               return -EINVAL;

I suspect you wanted "return NULL;" here.  I can fix that up.

Linus, Per ack?

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/