Re: [PATCH] cifs: set backing_dev_info on new S_ISREG inodes

[Jeff Layton]

On Wed, 29 Sep 2010 19:17:30 -0400
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Wed, Sep 29, 2010 at 09:49:54AM -0400, Jeff Layton wrote:
> > Testing on very recent kernel (2.6.36-rc6) made this warning pop:
> > 
> >     WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x65/0x70()
> >     Hardware name:
> >     Dirtiable inode bdi default != sb bdi cifs
> > 
> > ...the following patch fixes it and seems to be the obviously correct
> > thing to do for cifs.
> 
> See my patch in the btrfs/default_backing_dev_info thread for the real
> fix for the underlying issue.  But your patch won't harm either way.
> 

Thanks Christoph. I looked to NFS as a model for this, which does a
very similar thing in nfs_fhget. It's probably reasonable for us to set
this here in case there is further churn in the VFS for this sort of
thing.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/