Re: [PATCH] DMI to disable Vista compatibility on MSI GX723Notebook

[Joey Lee]

Hi Matthew, 

Thank's for your review!

æ åï2010-09-30 æ 14:25 +0100ïMatthew Garrett æåï
> On Thu, Sep 30, 2010 at 06:44:11PM +0800, Lee, Chun-Yi wrote:
> > The brightness control hotkey don't work with Vista compatibility
> > , because MSI GX723 included a infinite while loop in DSDT when
> > brightness control hotkey pressed.
> > MSI GX723 used Nvida video card, the infinite while loop must be a
> > workaround with Nvidia's Vista driver.
> 
> While this would work, it seems likely that the expected behaviour is 
> for the graphics driver to call the NVIF method. We don't do that as 
> yet, but when we do I'm worried about it potentially resulting in this 
> system being in an unexpected state (NVIF is used, but we don't claim to 
> be Vista). Can you add a comment indicating that it should be reverted 
> once nouveau grows support?
> 

I added comment to source code to remind need remove the MSI GX723 from
blacklist table after nouveau driver support NVIF method.

The attached file is new patch. Do I need send the patch to kernel mail
loop by git send-mail again?


Thank's
Joey Lee

>From c9541bb35389c3ccd96a49e9f30509e5bebae760 Mon Sep 17 00:00:00 2001
From: Lee, Chun-Yi <jlee@xxxxxxxxxx>
Date: Fri, 1 Oct 2010 16:28:29 +0800
Subject: [PATCH] DMI to disable Vista compatibility on MSI GX723 Notebook

The brightness control hotkey don't work with Vista compatibility
, because MSI GX723 included a infinite while loop in DSDT when
brightness control hotkey pressed.
MSI GX723 used Nvidia video card, the infinite while loop must be
a workaround with Nvidia's Vista driver.

This patch should be reverted  once nouveau grows support to call
NVIF method in DSDT.

Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxxxx>
---
 drivers/acpi/blacklist.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index f761960..fd24325 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -236,6 +236,23 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		},
 	},
 	{
+	/*
+	 * There have a NVIF method in MSI GX723 DSDT need call by Nvidia
+	 * driver (e.g. nouveau) when user press brightness hotkey.
+	 * Currently, nouveau driver didn't do the job and it causes there
+	 * have a infinite while loop in DSDT when user press hotkey.
+	 * We add MSI GX723's dmi information to this table for workaround
+	 * this issue.
+	 * Will remove MSI GX723 from the table after nouveau grows support.
+	 */
+	.callback = dmi_disable_osi_vista,
+	.ident = "MSI GX723",
+	.matches = {
+		     DMI_MATCH(DMI_SYS_VENDOR, "Micro-Star International"),
+		     DMI_MATCH(DMI_PRODUCT_NAME, "GX723"),
+		},
+	},
+	{
 	.callback = dmi_disable_osi_win7,
 	.ident = "ASUS K50IJ",
 	.matches = {
-- 
1.6.0.2