Re: [PATCH 6/7] sh: oprofile: Use perf-events oprofile backend
From: Paul Mundt
Date: Wed Oct 06 2010 - 17:03:26 EST
On Wed, Oct 06, 2010 at 08:45:07PM +0100, Matt Fleming wrote:
> On Wed, Oct 06, 2010 at 08:35:49PM +0200, Robert Richter wrote:
> > On 04.10.10 16:44:24, Matt Fleming wrote:
> > > Now that we've got a generic perf-events based oprofile backend we might
> > > as well make use of it seeing as SH doesn't do anything special with its
> > > oprofile backend. Also introduce a new CONFIG_HW_PERF_EVENTS symbol so
> > > that we can fallback to using the timer interrupt for oprofile if the
> > > CPU doesn't support perf events.
> > >
> > > Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
> > > ---
> > > arch/sh/Kconfig | 13 +++++
> > > arch/sh/oprofile/Makefile | 4 ++
> > > arch/sh/oprofile/common.c | 109 ++++---------------------------------------
> > > arch/sh/oprofile/op_impl.h | 33 -------------
> > > 4 files changed, 28 insertions(+), 131 deletions(-)
> > > delete mode 100644 arch/sh/oprofile/op_impl.h
> >
> > This patch looks good.
> >
> > We might merge it with patch 7/7.
>
> This patch was broken out for Paul's benefit to ease review. If he's
> happy for me to merge this with 7/7 then that's fine with me.
Yes, no objections from me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/