Re: [PATCH] forcedeth: reconfigure multicast packet filter onlywhen needed

From: Stephen Hemminger
Date: Sat Oct 09 2010 - 14:32:22 EST


On Sat, 9 Oct 2010 13:26:05 +0200
JindÅich MakoviÄka <makovick@xxxxxxxxx> wrote:

> +
> + /* current packet filter state */
> + u32 cur_pff;
> + u32 cur_addr[2];
> + u32 cur_mask[2];
> };

No big deal, but couldn't you just put those temporary variables
on the stack. and reread the current value before stopping.

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/